Back to Two Factor Authentication Support

Renatio
Renatio

Hi,

it will be very useful to allow disable logging in October Settings -> Logs -> Log Settings.

When this is disabled, it should not log plugin events to system logs.

Regards, Michal

VDLP
VDLP

Hi Michal,

Thanks for your idea. We will take this in consideration.

Renatio
Renatio

This is really annoying thing, because when I logged in into backend area there is a System Status widget that shows up Event Log and the number of logs. I used to see 0 of logs there most of the time and when I see more than 0 I think there were some errors or exceptions that I must handle. Now every time I logged into backend I see hundreds of records.

In addition in October there is no way to filter only exceptions or errors from the info logs you are adding.

I see this will also be very annoying for someone using external platforms for logging and maybe they receive an email when the log event is fired. They will receive hundreds of SPAM emails.

VDLP
VDLP

In version 3.2.0 a configuration option will be added to disable logging. Logging is enabled by default.

Logging is very important to detect suspicious events on your application. While it's annoying to some, it's essential to have (event) logging for others.

Please note: Sending log information using email is a bad behaviour and is not advised. Log information can contain sensitive information which should not be emailed outside of your hosting environment. Please make sure you respect your users' privacy.

Renatio
Renatio

Currently there is no way to override this config value, because your plugin config file is not placed inside config directory as mentioned in October documentation.

Changing your code to use published config works great, so please change this code:

if ($this->config->get('vdlp.twofactorauthentication::logging_enabled', true) === false) {
    return;
}

to this:

if ($this->config->get('twofactorauthentication.logging_enabled', true) === false) {
    return;
}

Thanks!

Last updated

VDLP
VDLP

Thank you for mentioning this. I have changed the code and pushed v3.2.2 which resolves this issue.

1-6 of 6