snakemaster
snakemaster

Hi, I have a Lando dev environment with oc-bootstrapper setup but the plugin dependencies won't get installed. oc-bootstrapper uses "php artisan plugin:install Vendor.Plugin" command to install. When I add a plugin with dependencies through the backend interface, all dependencies are downloaded as expected.

Is this normal behaviour or am I missing a flag or something?

October build 471

PHP 7.3

Composer 1.10.20

Last updated

mjauvin
mjauvin

Do you mean Plugin::$require dependencies or composer dependencies?

snakemaster
snakemaster

I mean Plugin::$require. So in my case Mohsin.OAuth2 requires Mohsin.Auth. OAuth2 is installed but Auth not. I thought the command artisan plugin:install would take care of that but I just checked the code and it appears that the interface has a separate callback where required plugins are taken care of..

So this question is answered

mjauvin
mjauvin

What seperate callback?

snakemaster
snakemaster

/modules/system/controllers/Updates::onInstallPlugin which is defined as data-handler in /modules/system/controllers/updates/_install_plugins.htm (and _plugin_form.htm)

Updates::onInstallPlugin calls appendRequiredPlugins to read the required plugins.

mjauvin
mjauvin

You're most definitely right. Can you please open an issue in github for this?

ref. https://github.com/octobercms/october/issues

Thanks!

mjauvin
mjauvin

If you could reference the github issue in here, that would be great!

Last updated

snakemaster
snakemaster

I had to take some time off programming, here it is: https://github.com/octobercms/october/issues/5521

mjauvin

1-9 of 9